> On Jan. 26, 2014, 7:22 a.m., István Kapcsándi wrote: > > src/CMakeLists.txt, line 17 > > <https://git.reviewboard.kde.org/r/115078/diff/3/?file=234996#file234996line17> > > > > maybe I'm wrong but my logic says that this should be > > install(FILES ${kglobalaccel_component_xml} DESTINATION > > ${DBUS_INTERFACES_INSTALL_DIR} RENAME > > kf5_org.kde.KGlobalAccel.Component.xml)
Good spot, but it is already fixed in 1d861e0d0513b5e67bdf71e4879ce405fcdcf971. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review48281 ----------------------------------------------------------- On Jan. 21, 2014, 4:24 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115078/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 4:24 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kglobalaccel > > > Description > ------- > > don't install dbus interface files in kglobalaccel, these overlap with the > equivalent files in kdelibs4 which causes problems for some distributions > > > Diffs > ----- > > src/CMakeLists.txt d48e92e > > Diff: https://git.reviewboard.kde.org/r/115078/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
