ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS
> gvgeo wrote in GridDelegate.qml:81 > Maybe need to add caption.visible check, instead of always removing 3 > gridUnits? > Was changed from 2 in the previous commit. If I do that, then grids where some delegates have captions and others don't display delegates of multiple sizes, which looks bad: F7881325: Screenshot_20200113_110453.png <https://phabricator.kde.org/F7881325> REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26634 To: ngraham, #vdg, #plasma, broulik Cc: gvgeo, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
