ngraham created this revision. ngraham added reviewers: dfaure, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision.
REVISION SUMMARY Right now, when you select text in the dialog box, an insertion point appears. It never disappears. This looks odd: F7882083: Weird Insertion point.png <https://phabricator.kde.org/F7882083> The insertion point allows you to navigate the text using the keyboard. But this is kind of pointless since you have to use the mouse to make the insertion point appear in the text in the first place, so you might as well just use the mouse to make the selection. This patch makes the text only mouse-selectable. Dolphin recently did the same thing for its Information Panel labels in D25241 <https://phabricator.kde.org/D25241> for the same reason. BUG: 416204 FIXED-IN: 5.67 TEST PLAN Try to open 6 items at once in Dolphin and click-and-drag in the message box text. Test is still selectable, but an insertion point is no longer created that cannot be removed. REPOSITORY R236 KWidgetsAddons BRANCH no-more-keyboard-selectability (branched from master) REVISION DETAIL https://phabricator.kde.org/D26649 AFFECTED FILES src/kmessagebox.cpp To: ngraham, dfaure, #frameworks, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
