dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > ahmadsamir wrote in kcoredirlister.h:595 > Thanks, fixed. Luckily it's a convenience function of sorts and replacing the > one instance it was used in KCoreDirLister was simple). Please write TODO KF6 remove, I see zero reason to keep this a virtual method, and lxr says nobody is using it. Same for doMimeFilter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26659 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns