ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY The issue with QRegularExpression::wildcardToRegularExpression() is that it's more strict in its interpretation of a wildcard, i.e. it makes it correctly work with file globbing patterns, meaning it would return this pattern "\\A(?:[^/]*)\\z" when called with "*", it excludes "/" which is a forbidden character in a filename, and it anchors the pattern (which when using QRegExp you'd used QRegExp::exactMatch()). TEST PLAN - Install falkon (and falkon-kde for kwallet integration) and log in to a website with a user name and a password and select to remember it when asked to. - Restart falkon and see if the login data is shown with this patch it should show the login data. REPOSITORY R311 KWallet BRANCH l-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D26734 AFFECTED FILES src/api/KWallet/kwallet.cpp src/runtime/kwalletd/backend/kwalletbackend.cc To: ahmadsamir, #frameworks, dfaure, apol Cc: blaze, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns