ndavis added a comment.

  This patch has a few problems and some things to consider.
  
  - Changing the size to `units.iconSizes.small` doesn't seem to break any 
layouts we have, but I have not done extensive testing with 3rd party widgets.
  - Is the size too small for touch input? If yes, that would mean the QStyle 
needs to be changed too.
  - For whatever reason, the checkboxes and radio buttons seem to grow in 
height and width by maybe 1px when hovered or checked. I can't figure out why 
and it still causes some pixel alignment issues, particularly with radio 
buttons.
  - Is it desirable to have multiple sizes for checkboxes and radio buttons? If 
not, then I suppose I should remove every size other than the one we choose 
from the svgs. Currently, I have 16, 22, 24 and 32px versions in both svgs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to