brute4s99 added inline comments.
INLINE COMMENTS
> notifybysnore.cpp:143
> {
> - Q_UNUSED(config);
> - // HACK work around that notification->id() is only populated after
> returning from here
> - // note that config will be invalid at that point, so we can't pass that
> along
> - QMetaObject::invokeMethod(this, [this, notification](){
> notifyDeferred(notification); }, Qt::QueuedConnection);
> -}
> + if(notification->id() == -1 && notification->eventId() ==
> QStringLiteral("notification")) {
> + return;
KNotif objects by default have `d->id = -1`
`notify()` is invoked by the base with -1 ID and later updated with the correct
ID and the actions.
Weirdly though, `pairingRequest` notification is not updated by the base, (that
is, the notification has all the information in the first invocation itself)
but still it has ID=-1 (because it's not updated later by the base, hence the
default ID).
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D26801
To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode,
Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, pawelkwiecinski, ctakano,
vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, fbampaloukas,
GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda,
timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, michaelh, SemperPeritus,
daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, MayeulC, lemuel,
menasshock, mikesomov, tctara, apol
