apol added a comment.
Looks good otherwise, this code is pretty well tested too, so I quite trust
we aren't breaking it horribly.
Trying to compile the rest of KDE Software against this patch would also be
useful.
INLINE COMMENTS
> kconfigloader.cpp:127
> } else if (name == QLatin1String("key")) {
> - m_key = attrs.value(i).trimmed();
> + m_key = attrs.at(i).value().toString().trimmed();
> }
You can trim before toString, this way we save some string allocations.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26890
To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
