dfaure added inline comments.
INLINE COMMENTS
> meven wrote in jobtest.cpp:2045
> Making an ioslave reading an env var for testing purposes is not a great
> alternative.
Does this mean the file could be made smaller again?
(to reduce disk-space requirements)
> file_unix.cpp:317
> +
> + if (testMode) {
> + QThread::usleep(150);
Maybe in testMode, the slave can become particularly slow for one given
filename.
E.g. if (testMode && fileName.contains("slow"))
This way, for other files, it remains fast, and for that one file it can be
really reliably slow (possibly sleeping for a whole second, or something like
that).
It also makes the more generically named "KIOSLAVE_FILE_ENABLE_TESTMODE"
available for enabling other kinds of "test mode" in the ioslave (the filename
acting as an additional switch).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25117
To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
