sitter created this revision. sitter added reviewers: dfaure, feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision.
REVISION SUMMARY the Result system was originally introduced to the FTP slave and now also makes an appearance in the SFTP slave. the system introduces a separation between logic and fronting API class to more tightly control when state changing calls (finished()/error()) are made. since these calls may only be made once during a given command multiple calls are at the very least indicative of bad code and at worst cause severe state confusion for the slavebase that it won't be able to recover from, rendering the slave instance broken. in the internal class Results are returned whenever an error can appear and these Results must be handled in some form. the only way to effectively produce user visible errors is to forward results up the call chain. TEST PLAN - connect - copy remotely - overwrite remotely - copy to local - overwrite to local - copy from local to remote - copy form local to remote and overwrite REPOSITORY R320 KIO Extras BRANCH sftp-errors REVISION DETAIL https://phabricator.kde.org/D27153 AFFECTED FILES sftp/kio_sftp.cpp sftp/kio_sftp.h To: sitter, dfaure, feverfew Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov