cgiboudeaux added inline comments.

INLINE COMMENTS

> COPYING:485
>  
> -    This library is free software; you can redistribute it and/or
> -    modify it under the terms of the GNU Lesser General Public
> -    License as published by the Free Software Foundation; either
> -    version 2.1 of the License, or (at your option) any later version.
> -
> -    This library is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -    Lesser General Public License for more details.
> -
> -    You should have received a copy of the GNU Lesser General Public
> -    License along with this library; if not, write to the Free Software
> -    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  
> USA
> +    SPDX-License-Identifier: LGPL-2.1-or-later
>  

The license shall not be altered :)

> LicenseRef-KDE-Accepted-LGPL.txt:13
> +GNU General Public License for more details.
> \ No newline at end of file


missing new line.

> comment.h:4-5
>  
> -    Copyright (c) 2010 Intel Corporation
> -    Author: Mateu Batle Sastre <mba...@collabora.co.uk>
> -
> -    This library is free software; you can redistribute it and/or
> -    modify it under the terms of the GNU Lesser General Public
> -    License as published by the Free Software Foundation; either
> -    version 2.1 of the License, or (at your option) version 3, or any
> -    later version accepted by the membership of KDE e.V. (or its
> -    successor approved by the membership of KDE e.V.), which shall
> -    act as a proxy defined in Section 6 of version 3 of the license.
> -
> -    This library is distributed in the hope that it will be useful,
> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> -    Lesser General Public License for more details.
> -
> -    You should have received a copy of the GNU Lesser General Public
> -    License along with this library.  If not, see 
> <http://www.gnu.org/licenses/>.
> +    SPDX-FileCopyrightText: 2010 Intel Corporation
> +    SPDX-FileCopyrightText: 2010 Mateu Batle Sastre <mba...@collabora.co.uk>
> +

I understand something different: the copyright holder is "Intel corporation", 
Mateu Batle Sastre is a file contributor.

See the FileContributor property: 
https://spdx.org/rdf/terms/dataproperties/fileContributor___-1635717172.html

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to