ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY When a process that KRun tried to run fails to launch: - Tell the user when the executable could not be found - If we find an executable but it exited abnormally (exit code != 0 ), inform the user about that and suggest he tries running it from terminal to get more details TEST PLAN (Proceed with the sudo commands at your own risk :)): - 'sudo chmod a-x /usr/bin/gwenview' then try opening a picutre with gwenview from e.g. dolphin, see the error message - break your system slightly: `sudo chmod a+x /usr/bin/gwenview & sudo mv /usr/lib64/libKF5Kipi.so.32.0.0 /usr/` then try opening a picture with gwenview from dolphin, see the error message - Finally: `sudo mv /usr/libKF5Kipi.so.32.0.0 /usr/lib64/` to unbreak your system BUG: 415567 FIXED-IN: 5.67 REPOSITORY R241 KIO BRANCH l-krun-exitcode (branched from master) REVISION DETAIL https://phabricator.kde.org/D27216 AFFECTED FILES src/widgets/krun.cpp src/widgets/krun_p.h To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns