davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision.
REVISION SUMMARY CommentsModel instances are owned by the engine. They are fetched through a getter with a cache, so ownership has to stay that way. QuickItemsModel should not be deleting them. BUG: 417802 TEST PLAN Got a valgrind log of the crash, which showed the issue (see attached bug report) Afterwards: Opened systemsettings, opened comments dialog Closed systemsettings REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D27468 AFFECTED FILES src/qtquick/quickitemsmodel.cpp To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
