----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/#review48600 -----------------------------------------------------------
src/config-strlcpy.h.cmake <https://git.reviewboard.kde.org/r/115203/#comment34339> I'm not convinced this is the correct fix; I don't think strlcpy *should* be exported by kcrash. Instead, I suspect the KCRASH_EXPORT should be removed from strlcpy-fake.c. - Alex Merry On Jan. 22, 2014, 3:13 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115203/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 3:13 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kcrash > > > Description > ------- > > Allow compiling with MSVC > > > Diffs > ----- > > src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 > src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 > > Diff: https://git.reviewboard.kde.org/r/115203/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
