-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115388/#review48607
-----------------------------------------------------------

Ship it!


Looks good to me.

- Aurélien Gâteau


On Jan. 29, 2014, 6:06 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115388/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 6:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> QtScript is not used. QtGui is actually used rather than QtWidgets.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 536f7f33ca6ac25fc87966bf2bb4e2fc248c37fd 
>   src/kdeclarative.h 84f313302c70f9161ab2244c735166e08947f252 
> 
> Diff: https://git.reviewboard.kde.org/r/115388/diff/
> 
> 
> Testing
> -------
> 
> Builds. Didn't find any reference to QtScript or QtWidgets when inspecting 
> source.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to