sitter created this revision. sitter added reviewers: ngraham, asn. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision.
REVISION SUMMARY unlike the dirent itering we do not need a separate stat call with this new api by instead itering on what are effectively stat-like objects. this simply runs before the regular itering which we still use to list shares and workgroups. browse_stat_path has been split into stat and udsentry-construction-from-stat so it can be used across both code paths. fun fact on the side: if there actually was a stat() api that returned libsmb_file_info, we could use that as well and forget about the stats structs in general :S BUG: 402988 FIXED-IN: 20.04.0 TEST PLAN - build samba 4.12 rc - list server - list share - list dir in share - on 4.7 - all of the above REPOSITORY R320 KIO Extras BRANCH readdirplus2 REVISION DETAIL https://phabricator.kde.org/D27520 AFFECTED FILES smb/CMakeLists.txt smb/config-smb.h.cmake smb/kio_smb.h smb/kio_smb_browse.cpp To: sitter, ngraham, asn Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
