leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision.
REVISION SUMMARY The old downloadwidget's update system would explicitly require a user to pick which download item to use for updating if there was more than one available. This work is an attempt at implementing this at the engine level, while also allowing for there to be no requirement to make an active choice, unless there is no way to deduce which of the various potential download items is the one we are trying to update. The current heuristics are: - If there is one downloaditem, that's what we're updating - If there are more, first try and see if one has the precise url as the previously installed payload - If that fails, check for filename matches (without the rest of the url) - Only if that fails, present the user with a choice Add an explicit update function in the QtQuick items model Fix erroneous uses of installItem, and use updateItem for updates in the QtQuick components BUG:417510 REPOSITORY R304 KNewStuff BRANCH fix-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D27544 AFFECTED FILES src/core/engine.cpp src/qtquick/qml/EntryDetails.qml src/qtquick/qml/NewStuffItem.qml src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml src/qtquick/quickitemsmodel.cpp src/qtquick/quickitemsmodel.h To: leinir Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns