davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision.
REVISION SUMMARY Before icons loaded internally with QIcon::fromTheme were being colored with the colors from the current global color scheme instead of the ones from the current Plasma Theme. Leading to visual bugs when the two differ. This happened because KIconLoader uses the global color scheme by default. A prominent case is the notification send by the network plasmoid when one successfully connected to a wireless network. It sets the icon "network-wireless-on" which is not included in Breeze icons (but is included in Breeze Plasma Theme). If the current icon theme is indeed Breeze, IconItem resorts to using QIcon::fromTheme and we end up with a wrong colored "network-wireless" icon. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 AFFECTED FILES src/declarativeimports/core/CMakeLists.txt src/declarativeimports/core/iconitem.cpp To: davidre Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
