zzag requested changes to this revision.
zzag added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> plasmawindowmanagement.cpp:363
>
> +void PlasmaWindow::Private::appmenuChangedCallback(void *data,
> org_kde_plasma_window *window, const char* service_name, const char*
> object_path)
> +{
Coding style: put whitespace before `*` and keep using snake_case.
void PlasmaWindow::Private::appmenuChangedCallback(void *data,
org_kde_plasma_window *window, const char *service_name, const char
*object_path)
> zzag wrote in plasma-window-management.xml:312
> and this one should be
>
> <!-- Version 10 additions -->
>
> <event name="application_menu_changed" since="10">
Also, please drop "_changed".
> plasmawindowmanagement_interface.h:234
> + */
> + void setApplicationMenuPaths(const QString& service_name, const QString&
> object_path);
> +
Coding style: put whitespace before `&` and use camelCase.
void setApplicationMenuPaths(const QString &serviceName, const QString
&objectPath);
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D27464
To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
