apol added a comment.

  +1 from me

INLINE COMMENTS

> apol wrote in smburl.cpp:67
> Can't we then just rename the method to `::cdUp()`?

it can return void too, nobody is checking it anyway.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27801

To: sitter, ngraham
Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

Reply via email to