nicolasfella added inline comments. INLINE COMMENTS
> leinir wrote in kaccountsdplugin.h:57 > This still introduces a API break, though... Which seems especially silly > given the arguments aren't actually used. Perhaps add a new ctor, and have > the one without the arguments call the new one, but also make a qwarning (or > something similar) note that it's using an old ctor and really out to upgrade? This shouldn't be in this diff at all REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks