hallas marked 4 inline comments as done. hallas added inline comments. INLINE COMMENTS
> bruns wrote in fstabhandling.cpp:374 > For now just keep it here, I can see now benefit of making it public (even > unexported). > > And thanks for baring with my nitpicking ;-), this now is pretty much what I > hoped for. No problem, I really appreciate the thorough review feedback you provide. I definitely prefer to take more time and get things right, then to rush things and potentially get them wrong. So, have you had a chance to test out the patch? Do you think it is ready to land? I will also start to prepare the next patch as part of splitting up the mega-refactor patch from D26600 <https://phabricator.kde.org/D26600> REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
