----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115345/ -----------------------------------------------------------
(Updated Feb. 3, 2014, 6:24 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description ------- 1) Use #pragma pack instead of __attribute__((packed)) This is available on all supported compilers, the attribute does not exist for MSVC -------------------------------------------------- 2) Use q{To,From}BigEndian instead of hton* and ntoh* These functions don't seem to be available as inline functions on win32 Diffs ----- src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388 src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294 src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71 Diff: https://git.reviewboard.kde.org/r/115345/diff/ Testing ------- didn't compile before, does now Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel