> On Feb. 3, 2014, 9:07 p.m., Martin Gräßlin wrote: > > src/kstartupinfo.cpp, lines 1250-1254 > > <https://git.reviewboard.kde.org/r/115450/diff/1/?file=241654#file241654line1250> > > > > why is this introduced again? > > Alexander Richardson wrote: > NET::OnAllDesktops does not exist if KWINDOWSYSTEM_HAVE_X11 is false. I > don't know what the correct fix is, but this way it compiles
that was a fault on our side, we assumed that NET::OnAllDesktops is globally available. I'll fix that tomorrow with another review request. The compile fix is wrong as that would result in wrong behavior on e.g. Wayland without X11. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115450/#review48854 ----------------------------------------------------------- On Feb. 3, 2014, 7:44 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115450/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 7:44 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > ------- > > Fix build without KWINDOWSYSTEM_HAVE_X11 > > > Diffs > ----- > > src/kstartupinfo.cpp c843c2991a279a136fbccdf4e7c5ae5dd8358c0e > > Diff: https://git.reviewboard.kde.org/r/115450/diff/ > > > Testing > ------- > > Compiles, not sure whether fix is correct > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel