dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  It would be good to add a link to the spec as a code comment -- but I see 
that the docu isn't merged yet, so can't be done yet.

INLINE COMMENTS

> kprocessrunner.cpp:43
> +
> +#include <thread>
> +#include <mutex>

unused? std::call_once and std::once_flag come from <mutex>

> kprocessrunner.cpp:307
> +
> +    QList<uint> pidList = {static_cast<quint32>(m_process->pid())};
> +

const

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Reply via email to