ahmadsamir added a comment.
In D28161#634949 <https://phabricator.kde.org/D28161#634949>, @sitter wrote: > Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Unit tests are indeed useful... > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client That's confusing; but OK, I'll revert that part of the diff. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol Cc: kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
