davidedmundson added inline comments. INLINE COMMENTS
> SettingStateIndicator.qml:30 > +Item { > + id: root > + This is a faux-button. Which means it needs all the relevant: Accessible.blah roles to be manually added Should it be in the tab focus chain? (or we could just inherit ToolButton) > SettingStateIndicator.qml:38 > + > + width: 16 > + height: 16 Setting root width/height inside a component is almost always not what you want. Use implicitWidth/implicitHeight. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns