dfaure added inline comments. INLINE COMMENTS
> file_unix.cpp:179 > + keyLen = strlen(keyPtr); > + QByteArray key(keyPtr); > +#elif HAVE_SYS_EXTATTR_H Ah, I see, you still need to call `strlen()` yourself, for the code at the end of the iteration.... Well, then you might as well pass the value to the constructor so it doesn't need to do the same. const QByteArray key(keyPtr, keyLen); after the #endif, since it would now be the exact same line of code for both cases. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh
