broulik planned changes to this revision. broulik added inline comments. INLINE COMMENTS
> kossebau wrote in knotificationjobuidelegate.cpp:24 > Not using a nested class `Private` but a normal separate one like here to be > named `KNotificationJobUiDelegatePrivate` seems more simple, avoids the need > for things like Q_DECL_HIDDEN. > > At least recently most code uses the latter, so would be good to standardize > on that. I thought we wanted to migrate towards nested `Private` class? :0 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28295 To: broulik, #frameworks, nicolasfella, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns