dfaure created this revision.
dfaure added reviewers: kossebau, apol, cgiboudeaux.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Not passing CMAKE_INSTALL_PREFIX is a weird thing to do. The test shows
  "Installing in ." and some values like KDE_INSTALL_FULL_EXECROOTDIR
  become "/" which is considered relative on Windows.
  
  The test that passes /usr to CMAKE_INSTALL_PREFIX actually passes on
  Windows. Pass /tmp to the other test, remove the test without prefix.

TEST PLAN
  Passes on Linux, not tested on Windows, CI will do that

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28409

AFFECTED FILES
  tests/CMakeLists.txt

To: dfaure, kossebau, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

Reply via email to