> On Feb. 4, 2014, 11:46 p.m., Alex Merry wrote: > > Hmm... I feel that KCompletionMatchesWrapper is in the wrong place, but I'm > > not entirely sure where it *should* go. Well, it's not in a public header, > > so that's far less urgent (although a potential later task would be to move > > the private methods of KCompletion, some of which take > > KCompletionMatchesWrapper as an argument, to KCompletionMatchesPrivate). > > > > Anyway, resolve the last two issues, and it can go in.
Yes, I noticed the same problem. After the whole cleanup everything will hopefully be clearer :-) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/#review48988 ----------------------------------------------------------- On Feb. 4, 2014, 11:08 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115419/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 11:08 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > To make code clearer, split KCompletionMatches. > > > Diffs > ----- > > src/CMakeLists.txt ae4a656 > src/kcompletion.h f197fc3 > src/kcompletion.cpp c684727 > src/kcompletion_p.h a8dedae > src/kcompletionmatches.h PRE-CREATION > src/kcompletionmatches.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115419/diff/ > > > Testing > ------- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
