ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY Changing the icon of a dir on a samba share doesn't seem to have an effect, this is intentional as reading .directory would impact network resources negatively, see the bug report for more details. BUG: 205954 TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kprop (branched from master) REVISION DETAIL https://phabricator.kde.org/D28679 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
