ivan added inline comments.

INLINE COMMENTS

> previewjob.cpp:697
>                   
> !currentItem.item.url().adjusted(QUrl::RemoveFilename).toLocalFile().startsWith(thumbRoot))
> -                && !sequenceIndex;
> +                && !sequenceIndex && !isEncrypted;
>      QImage thumb;

Since you are already changing this, move these two checks to the line after 
`bSave` - short-circuit logic to skip calling `->property` and the rest if 
these two are not satisfied.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28746

To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Reply via email to