dfaure added a comment.

  TestTrash::renameDirInTrash makes the dir cache invalid (it still lists 
trashDirFromHome). I think because of the optimization that we don't always 
care about the size... but this had the side effect of keeping the cache 
uptodate.... I wonder if the test is too strict and an old cache isn't better 
than keeping it coherent at extra cost... I'll dig further.

INLINE COMMENTS

> trashimpl.cpp:411
>  
> -    const qulonglong pathSize = DiscSpaceUtil::sizeOfPath(origPath);
> -

This was done unconditionally...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to