----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49036 -----------------------------------------------------------
Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. src/ktranscript.cpp <https://git.reviewboard.kde.org/r/115485/#comment34637> nitpick: no need for explicit since the ctor takes two mandatory arguments src/ktranscript.cpp <https://git.reviewboard.kde.org/r/115485/#comment34635> nitpick: missing curly braces - Aurélien Gâteau On Feb. 4, 2014, 7:55 p.m., Kevin Krammer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115485/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 7:55 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a > tier1 framework. > Needs more testing and likely fixing > > > Diffs > ----- > > src/ktranscript.cpp 2fde5c2 > CMakeLists.txt 87c27e6 > src/CMakeLists.txt 55fa512 > > Diff: https://git.reviewboard.kde.org/r/115485/diff/ > > > Testing > ------- > > Unittest runs, but the test script is very minimal and would need to be > extendedb by someone who understands the scripting requirements. > There is also a weird crash at test shutdown, in QThreadStorage. As far as I > can tell I did not change anything related to threads though. > > > Thanks, > > Kevin Krammer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel