alex created this revision. alex added reviewers: KNewStuff, meven, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision.
REVISION SUMMARY As described in the bug report the uninstallation failed, but the service was marked as removed. Now the service gets only marked as uninstalled if the script runs without an error. If there is an error the user gets a popup. TEST PLAN Set the exit code to 1 and try to install a dolphin plugin. You should get an error message. Without modifying the exit code you should be able to install services. The manual deletion can be tested by removing the installed service file. for example: rm ~/.local/share/kservices5/ServiceMenus/iso_mounter_unmounter.desktop Then the uninstaller will crash: "Failed to remove .desktop file ... No such file or directory" Then you delete the installed file manually: rm ~/.local/share/servicemenu-download/iso_mounter_unmounter.desktop And now you can click the uninstall button and it gets removed from the list of installed services. REPOSITORY R304 KNewStuff BRANCH bugfix_install_uninstall_messages (branched from master) REVISION DETAIL https://phabricator.kde.org/D29123 AFFECTED FILES src/core/CMakeLists.txt src/core/engine.cpp src/core/installation.cpp src/core/installation.h To: alex, #knewstuff, meven, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
