davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:21
> You've probably meant Q_DECL_HIDDEN, right?
> 
> On an unrelated note: there are valid arguments against nested private 
> classes so it would be really nice if we revisit this topic in the new repo.

yeah, that one

> there are valid arguments against nested private classes so it would be 
> really nice if we revisit this topic in the new repo.

Sure

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Reply via email to