broulik added inline comments.
INLINE COMMENTS
> KeySequenceItem.qml:57
> + ToolTip.visible: hovered
> + ToolTip.delay: 1000
> + ToolTip.text: _tr.i18n("Click on the button, then enter the
> shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl
> key and press A.")
Can we use the non-attached version here please since it's not likely (except
maybe System Tray delegate) to be used in large quantities?
> KeySequenceItem.qml:58
> + ToolTip.delay: 1000
> + ToolTip.text: _tr.i18n("Click on the button, then enter the
> shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl
> key and press A.")
> + ToolTip.timeout: 5000
Is this `_tr` thing we could also improve (separately o/c)?
> KeySequenceItem.qml:61
>
> onCheckedChanged: {
> if (checked) {
Probably can now use `onToggled`?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D29292
To: davidedmundson, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
