----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115495/#review49120 -----------------------------------------------------------
Instant issue: the README.md claims that yapgvb is only needed to generate the diagrams, but not having it installed causes kgenframeworksapidocs to fail with an ImportError (it imports depdiagram, which imports yapgvb). You need to catch and handle that ImportError in a sensible way (perhaps produce an error if the user asked for dep diagrams). Second thing: why call dot directly instead of using yapgvb to render to PNG? Although it looks like tred might not be an option in that case... Third thing: have you tested with python3? - Alex Merry On Feb. 5, 2014, 2:43 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115495/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 2:43 p.m.) > > > Review request for KDE Frameworks, Alex Merry and Aurélien Gâteau. > > > Repository: kapidox > > > Description > ------- > > This big patch moves code from depdiagram-prepare and depdiagram-generate to > Python modules and make kgenframeworksapidox use those modules to generate > the dependency frameworks. > > This only happens when it is called with the --dependency-diagrams option. > > Since the patch is going to be painful to review here, I also uploaded the > patchset here: http://agateau.com/tmp/kapidox-depdiagram-integration > > > Diffs > ----- > > src/depdiagram-generate adabe27 > src/depdiagram-prepare 3d133d9 > src/kapidox/__init__.py 0024723 > src/kapidox/data/dependencies.md 5e30d09 > src/kapidox/data/dependencies.md.mustache PRE-CREATION > src/kapidox/depdiagram/__init__.py e69de29 > src/kapidox/depdiagram/frameworkdb.py 9b63c8b > src/kapidox/depdiagram/generate.py PRE-CREATION > src/kapidox/depdiagram/prepare.py PRE-CREATION > src/kgenframeworksapidox ac34f2c > > Diff: https://git.reviewboard.kde.org/r/115495/diff/ > > > Testing > ------- > > Generated the whole thing, works as expected. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
