nicolasfella added a comment.
In D29391#662471 <https://phabricator.kde.org/D29391#662471>, @broulik wrote: > Generally +1 > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? I'll take a look > Not a fan of the timer. Me neither, but the widgets code has this too, so I kept it. I can remove it though if we decide we don't want it > Also, we might want to deprecate the `QWidget` one now? That's my plan, but I still need to port some things REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns