meven marked an inline comment as done.
meven added inline comments.
INLINE COMMENTS
> dfaure wrote in previewjob.cpp:717
> This here also breaks compatibility. Add a KF6 TODO to start the
> serialization with a version number.
>
> Meanwhile a hack is needed, like `if (iFormat & 0x1000) { iFormat &= 0xFFF;
> str >> imgDevicePixelRatio; }`
> and of course setting that 0x1000 flag in the slaves that have been updated
> to provide the pixelratio.
I am not sure the values you gave for the hack bitmask are correct, iFormat is
quint8, so how come it contain 0x1000
> dfaure wrote in thumbcreator.h:183
> You need to do like we once did: define an interface that inherits from
> ThumbCreator.
> Call it V3....
>
> In the job, use dynamic_cast to test whether the object provided by the
> kioslave supports the V3 interface or not.
I guess you mean in the thumbnail kio regarding instantiating Thumbcreator.
Anyway it works locally.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29397
To: meven, dfaure, broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
