bruns created this revision. bruns added reviewers: Frameworks, Baloo, ngraham, astippich, mgallien. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision.
REVISION SUMMARY Audible AAX files are standard ISO Base Media File Format (ISOBMFF) files, often called "MP4" or "Quicktime". Metadata can thus be extracted with the taglib "MP4" code path. The test files have been created with ffmpeg and then edited with okteta/ exiftool to resemble real AAX files, which can not be included for copyright reasons. https://gitlab.freedesktop.org/xdg/shared-mime-info/-/merge_requests/76 is required to correctly detect AAX files. TEST PLAN ctest REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D29454 AFFECTED FILES autotests/samplefiles/no-meta/test.aax autotests/samplefiles/nocoverage_test.aax autotests/taglibextractortest.cpp autotests/taglibextractortest.h src/extractors/taglibextractor.cpp src/extractors/taglibextractor.json To: bruns, #frameworks, #baloo, ngraham, astippich, mgallien Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams