----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/#review49240 -----------------------------------------------------------
Urgh, we were hoping this wouldn't be an issue. This commit would break #include <attica/event.h>, so it cannot go in. All "namespaced" frameworks do it this way already btw, see kparts for instance: -- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KParts/KParts/ReadWritePart -- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KParts/kparts/readwritepart.h Since there is no filename clash, what is the issue if these end up in the same folder on Mac OSX? - David Faure On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115541/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 7:37 p.m.) > > > Review request for KDE Frameworks. > > > Repository: attica > > > Description > ------- > > Case-insensitive filesystems don't like the Attica vs. attica pathes, when > installing, the headers would all be messed up. Instead, install everything > to include/KF5/Attica to be in line with the other frameworks. > > Note - this might not be the best solution, but we need one in order to > deploy on Mac OS X :) > > > Diffs > ----- > > src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d > > Diff: https://git.reviewboard.kde.org/r/115541/diff/ > > > Testing > ------- > > Only on Mac OS X > > > Thanks, > > Harald Fernengel > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
