ahmadsamir added inline comments. INLINE COMMENTS
> krun.h:216 > + * @deprecated since 5.6, use runApplication instead. > + * @deprecated since 5.71, use ApplicationLauncherJob instead. > + * @code I don't think you want both @deprecated? > krun.h:229 > */ > - KIOWIDGETS_DEPRECATED_VERSION(5, 6, "Use KRun::runApplication(const > KService &, const QList<QUrl> &, QWidget *, RunFlags, const QString &, const > QByteArray &") > + KIOWIDGETS_DEPRECATED_VERSION(5, 6, "Use KIO::ApplicationLauncherJob, > see API docs for a code sample") > static bool run(const KService &service, const QList<QUrl> &urls, > QWidget *window, You meant "5, 71" > krun.h:369 > * @return @c true on success, @c false on error > - * @deprecated since 5.31, use runUrl() with RunFlags instead. > + * @deprecated since 5.31, use OpenUrlJob instead. > + * @code But OpenUrlJob is in 5.71 not 5.31? people will be reading that on api.kde.org not only in 5.71 header files, right? maybe: @deprecated since 5.31 Since 5.71, use OpenUrlJob instead. > krun.h:380 > */ > - KIOWIDGETS_DEPRECATED_VERSION(5, 31, "Use KRun::const QUrl &, const > QString &, QWidget *, RunFlags, const QString &, const QByteArray &") > + KIOWIDGETS_DEPRECATED_VERSION(5, 31, "Use KIO::OpenUrlJob, see API docs > for a code sample") > static bool runUrl(const QUrl &url, const QString &mimetype, QWidget > *window, The same issue 5.31 vs 5.71. > krun.h:452 > * @param asn Application startup notification id, if any (otherwise ""). > * @return @c true on success, @c false on error > + * @code Missing @deprecated. > krun.h:599 > */ > - void slotTimeout(); // KDE5: rename to slotNextStep() or something like > that > + void slotTimeout(); > So, you're keeping the name slotTimout? I guess after 5-10 years, no point changing it :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29547 To: dfaure, ahmadsamir, broulik, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns