meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kdeplatformfiledialoghelper.cpp:226
> +    //passing non-local files as the working directory is not supported.
> +    //See QFileDialogPrivate::initialSelections
> +    //Selectingg files should be done through the correct method.

QFileDialogPrivate::initialSelection

> kdeplatformfiledialoghelper.cpp:227
> +    //See QFileDialogPrivate::initialSelections
> +    //Selectingg files should be done through the correct method.
> +    m_fileWidget->setUrl(directory);

typo Selectingg

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to