ahmadsamir added a comment.
In D29782#672157 <https://phabricator.kde.org/D29782#672157>, @dfaure wrote: > Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work) I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it doesn't set it, I could be wrong, though. > and another one in jobtest.cpp for a http URL (e.g. to test which error code we're getting, if any?) I'll look into that next. > + call mostLocalUrl() on a "normal" StatJob in testtrash.cpp Same as the first point :) [...] REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns