meven added inline comments.

INLINE COMMENTS

> alex wrote in kpluginselector.cpp:855
> > moduleInfo is part of the ctor here, so the fileName is already available 
> > indirectly.
> 
> Yes, but the KCModuleProxy is just a wrapper class for the KCModule.
> The actual KCModule gets created in kcmoduleloader.cpp line 93+.
> 
> PS: The moduleInfo is also available there, but I don't see any elegant way 
> to make it available to the KCModule other than a property or appending it to 
> the list of arguments.
> 
> >   A good thing would be to avoid having an option for such a niche usage 
> > although legitimate.
> 
> Always open to suggestions 😃

Seems like a property would make sense, after all it is about it, or a ref to 
the KCModuleInfo

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to