alex added inline comments. INLINE COMMENTS
> kossebau wrote in abstractrunner.h:154 > Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot > instead of comma) Yes. I accidentally did it this way, because in German you use a comma :D > kossebau wrote in abstractrunner.h:156 > ECMGenerateExportHeader now (for 5.71) features support for using a different > version number to be shown in the compiler warning: > KRUNNER_DEPRECATED_VERSION_BELATED > > So you could make this: > > KRUNNER_DEPRECATED_VERSION_BELATED(5, 71, 5, 0, "No longer use, feature > removed") This is pretty cool, many thanks again. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause, meven Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
