dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kicontheme.cpp:761
> } else if (tmp.isEmpty()) {
> // do nothing. key not required
> } else {
(OK, if this key is not required then surely unknown values are fine too..)
> kicontheme.cpp:774
> qWarning() << "Invalid Type=" << tmp << "line for icon theme: " <<
> constructFileName(QString());
> - return;
> + mType = KIconLoader::Threshold;
> }
So, if index.theme says `Type=Fixed`, why did you change this line? It should
work without this second change, only the first one seems useful.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D29668
To: xuetianweng, #frameworks, dfaure, apol
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,
bruns
