bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > jobtest.cpp:487 > + attrs["user.fattr.with.a.lot.of.namespaces"] = "true"; > + attrs["user.name with space"] = "value with spaces"; > + return attrs; this obviously needs test cases with a key ley/value len > 512, to check the the array-to-short/resize path. > file_unix.cpp:155 > + if (errno == ERANGE) { > + keylist.resize(listlen + 512); > + } This is still definitely wrong ... > file_unix.cpp:200 > + if (valuelen == -1 && errno == ERANGE) { > + value.resize(valuelen + 512); > + } also wrong ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh